Louisa jones #2
Open
Louisa jones #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed javascript for dynamic adds
Changed the css to improve the appearance of the card flip. Added additional Json file. That change is not final.
Restructured the Card class. Added promises to fix error of data or variables not being ready.
for tablet sizes. Modified sizing of elements to be more responsive. Deleted extra json file.
unused code.
|
🙏 Thanks for your pull request @Elita1Arcee, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Here's my submission. It was fun. I learned a lot about the importance of planning, the DOM, Classes. This is my first challenge submission so, hopefully I remembered the steps. Thank you for your help.