Problem: mtrie use of non-tail recursion leads to stack overflow #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: only process for sub/cancel if the messages are actually sub/cancel. Regression introduced by cf9ccbb which tried to skip non-sub/cancel processing for PUB.
Solution: convert add and rm functions to iterative algorithms
|
@somdoron could you have a look when you got a second, please |
|
Looks good, by the way, it seems the add was tail recursive, was it a problem as well? |
It is in case the compiler doesn't optimize it away, so we can't be 100% sure on our end, so I changed it too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.