Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow overriding block_on_no_clients queue param #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Allow overriding block_on_no_clients queue param #187

wants to merge 1 commit into from

Commits on Feb 5, 2024

  1. feat: Allow overriding block_on_no_clients queue param 

    In the current implementation, when a SUB provider is restarted, the
library just hangs without detecting connection loss.
This happens because on disconnect a client is kicked out of the queue,
as since for all the socket queues block_on_no_clients is set to true,
it hangs indefinitely.

I'm unsure what would be the effect of setting block_on_no_clients to
false globally (though it seems reasonable), so in this PR an ability
to override this value is introduced via SocketOptions is added.
    @bemyak
    bemyak committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    b36243f View commit details
    Browse the repository at this point in the history