New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax ValueInput constraint for SkipUntil and SkipThenRetryUntil #529

Merged

zesterer merged 1 commit into zesterer:main from tesujimath:skip-for-general-input

Sep 20, 2023

Contributor

tesujimath commented Sep 20, 2023

Removing ValueInput constraint allows to use these with e.g. BorrowInput.

There was nothing here that required ValueInput over underlying Input.


          SkipUntil and SkipThenRetryUntil only need Input

b4c857d

Removing ValueInput constraint allows to use these for e.g. BorrowInput.

zesterer approved these changes

View reviewed changes

Owner

zesterer left a comment

Thanks, definitely a welcome improvement!

zesterer merged commit b6c5df6 into zesterer:main

3 of 4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet