Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Or path choosing #678

Open
wants to merge 1 commit into
base: legacy
Choose a base branch
from

Conversation

KrosFire
Copy link

resolves #677

The Or parser will now choose a path that succeeded first and if both fail it will try to figure out witch error is better suited

@zesterer
Copy link
Owner

Oh, this is for 0.9? Hmm...

I am somewhat less inclined to merge this because 0.9 is not maintained any longer, bar fixes for significant bugs. Is there a particular reason that you're using 0.9 instead of 1.0?

@KrosFire
Copy link
Author

The first version is still in alpha and is not the default in cargo so I was using 0.9.3 :D

If I understand correctly the current implementation of Or in the main branch it's just a syntax sugar for choice, which returns first result that parses with success, so there is no need to change anything.

Is the newest version stable enough and does it have all the functionalities to use instead of 0.9? I'm looking forward to it because of the performence and dropping the Rc

@zesterer
Copy link
Owner

zesterer commented Oct 15, 2024

Is the newest version stable enough and does it have all the functionalities to use instead of 0.9?

I'd say so, yes. There are a few changes to come that are technically breaking, but only in the most abstract sense: Almost all real parsers written against 1.0-alpha should compile or compile with only very minor changes come 1.0 stable. The design is maybe 85% there, and the features that exist now aren't going anywhere. I'm avoiding a stable release for now purely because there are some minor API burrs still to sand down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants