Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict with AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM #12

Closed
AhmedSaadShrief opened this issue Jun 29, 2020 · 7 comments
Closed

conflict with AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM #12

AhmedSaadShrief opened this issue Jun 29, 2020 · 7 comments

Comments

@AhmedSaadShrief
Copy link

AhmedSaadShrief commented Jun 29, 2020

when usings LocaleAwareApplication() instead of Application() ,
AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM don't work correctly .

@AlexSheva-mason
Copy link

I can confirm that as well, just checked.

gunhansancar added a commit that referenced this issue Jul 6, 2020
gunhansancar added a commit that referenced this issue Jul 6, 2020
@gunhansancar
Copy link
Member

Released v1.0.4 version with the with for the uimode issues.
In the sample project I added dark mode support and it seems working for all versions of Android so far.
Please check the new version and let me know if it fixes the issue

@gunhansancar
Copy link
Member

Closing due to no response. If the changes not helpful please create a new ticket.

@Alireza-Farahani
Copy link

Using version 1.1.4, I face the same issue.

@gunhansancar
Copy link
Member

@Alireza-Farahani did you try the sample project, as it works there?

@gunhansancar gunhansancar reopened this Dec 25, 2020
@Alireza-Farahani
Copy link

Alireza-Farahani commented Dec 25, 2020

@gunhansancar I tried the sample and I can manually toggle dark/light with success but enabling dark mode through system settings doesn't affect the sample.

@gunhansancar
Copy link
Member

This could be related to #32 So let's continue on that ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants