-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented configuration block to access other setting like font scale. #11
base: master
Are you sure you want to change the base?
Conversation
Bump version
Hi @DastanIqbal thank you for your contribution. It looks great. |
Okay not an issues but when I used the library, then I couldn't change other setting and its restricted to library, because the block I have added that should run along with locale setting, otherwise changes won't reflect in app, like I added accessiblity features where I need to increase/decrease app text size, that wasn't working, because of the limitation, and block should run before setting |
Similar issues also arise about the dark mode, so I will accept the PR with some modifications, I'll send a commit on top of your PR. I should make it dynamically changeable as well like on button click etc. |
Cool Thanks |
I have fixed conflicts and added Accessibility Sample for font Size in MainActivity, |
# Conflicts: # build.gradle # localehelper/src/main/java/com/zeugmasolutions/localehelper/LocaleHelper.kt
This PR help devs to change configuration setting along with locale. For eg. Font Scale, uiMode, colorMode etc