Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented configuration block to access other setting like font scale. #11

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

DastanIqbal
Copy link

This PR help devs to change configuration setting along with locale. For eg. Font Scale, uiMode, colorMode etc

Iqbal Ahmed and others added 2 commits June 12, 2020 03:50
@gunhansancar
Copy link
Member

Hi @DastanIqbal thank you for your contribution. It looks great.
However, I'm not sure if this library should allow/enable such configuration changes.
Because IMO this library is only about locale changes, nothing more and nothing less.

@DastanIqbal
Copy link
Author

Okay not an issues but when I used the library, then I couldn't change other setting and its restricted to library, because the block I have added that should run along with locale setting, otherwise changes won't reflect in app, like I added accessiblity features where I need to increase/decrease app text size, that wasn't working, because of the limitation, and block should run before setting createConfigurationContext and its blocks developer.

@gunhansancar
Copy link
Member

Similar issues also arise about the dark mode, so I will accept the PR with some modifications, I'll send a commit on top of your PR. I should make it dynamically changeable as well like on button click etc.

@DastanIqbal
Copy link
Author

Cool Thanks

@DastanIqbal
Copy link
Author

I have fixed conflicts and added Accessibility Sample for font Size in MainActivity,
currently, I am using forked in my app. because we can't change font size in the current implementation

.idea/misc.xml Outdated Show resolved Hide resolved
Iqbal Ahmed added 2 commits September 27, 2020 12:26
# Conflicts:
#	build.gradle
#	localehelper/src/main/java/com/zeugmasolutions/localehelper/LocaleHelper.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants