Revert to system default #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 15, 2021 20:48
…ion. Misc cleanup.
tgvoskuilen
commented
May 26, 2021
| toURButton.setOnClickListener { updateLocale(Locales.Urdu) } | ||
| language_picker.setOnCheckedChangeListener { _, checkedId -> | ||
| when(checkedId) { | ||
| R.id.language_default -> clearLocaleSelection() |
There was a problem hiding this comment.
If you change this to updateLocale(LocaleHelper.systemLocale) you can run this example app with the existing library to replicate the issues.
tgvoskuilen
commented
May 26, 2021
| */ | ||
| fun hasLocaleSelection(context: Context): Boolean { | ||
| val prefs = getPreferences(context) | ||
| return prefs.contains(SELECTED_COUNTRY) && prefs.contains(SELECTED_COUNTRY) |
There was a problem hiding this comment.
Whoops, noticed the second one here should be SELECTED_LANGUAGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the changes needed to get the locale-selection UI working and skip the screen updating. To see what the issue was you could try the updated example app without the library changes. Hope it's helpful!