gltfpack: Allow per-texture-class control for texture limit #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to texture scaling, there are cases where setting individual limits for different classes can be helpful. Using -ts works when the input assets are known to have reasonable sizes (and allows to preserve the size considerations for individual materials), but for a completely arbitrary input, it can be helpful to enforce a lower limit for normal maps or attribute maps when they use UASTC. Since we now have a per-kind limit, the power-of-two validation is a little more cumbersome to do; for now just remove it as it's unclear that it's practically useful. If -tl is used to specify a non-power-of-two limit, -tp will simply round it using the existing logic.
Instead of replicating two different loops in a few different options, use a helper function that supports an optional mask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to texture scaling, there are cases where setting individual
limits for different classes can be helpful. Using -ts works when the
input assets are known to have reasonable sizes (and allows to preserve
the size considerations for individual materials), but for a completely
arbitrary input, it can be helpful to enforce a lower limit for normal
maps or attribute maps when they use UASTC.
Follow up for #798.