Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorring skeleton of SetCriterion #125

Merged
merged 22 commits into from
Jul 16, 2021
Merged

Conversation

zhiqwang
Copy link
Owner

Fixing #60

@zhiqwang zhiqwang mentioned this pull request Jun 25, 2021
9 tasks
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #125 (1c9431e) into master (82d6afb) will increase coverage by 0.77%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   83.56%   84.34%   +0.77%     
==========================================
  Files           8       11       +3     
  Lines         779      811      +32     
==========================================
+ Hits          651      684      +33     
+ Misses        128      127       -1     
Flag Coverage Δ
unittests 84.34% <96.42%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_engine.py 94.32% <93.65%> (-5.68%) ⬇️
test/test_hooks_utils.py 100.00% <100.00%> (ø)
test/test_models.py 100.00% <100.00%> (+5.02%) ⬆️
test/test_models_anchor_utils.py 100.00% <100.00%> (ø)
test/test_models_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d6afb...1c9431e. Read the comment docs.

@zhiqwang zhiqwang added code quality Code format and unit tests enhancement New feature or request labels Jun 25, 2021
@zhiqwang zhiqwang changed the title Refactor anchor / targets assignment Refactorring skeleton of SetCriterion Jul 16, 2021
@zhiqwang
Copy link
Owner Author

Let's merge this PR firstly, and work on a new stream.

@zhiqwang zhiqwang merged commit 947956f into master Jul 16, 2021
@zhiqwang zhiqwang deleted the refactor-anchor-assigner branch July 16, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code format and unit tests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant