Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output names in ONNX and simplify the unit-test #151

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Aug 25, 2021

  • Add output names in ONNX
  • Simplify the unit-test in test_onnx.py

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zhiqwang zhiqwang added the code quality Code format and unit tests label Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #151 (a123bc5) into master (ed73a5d) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

❗ Current head a123bc5 differs from pull request most recent head 2a1d997. Consider uploading reports for the commit 2a1d997 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   84.50%   84.19%   -0.32%     
==========================================
  Files          12       12              
  Lines         813      797      -16     
==========================================
- Hits          687      671      -16     
  Misses        126      126              
Flag Coverage Δ
unittests 84.19% <100.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_onnx.py 85.71% <100.00%> (-2.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed73a5d...2a1d997. Read the comment docs.

@zhiqwang zhiqwang changed the title Add output names in ONNX Add output names in ONNX and simplify the unit-test Aug 25, 2021
@zhiqwang zhiqwang merged commit 6f8cbf9 into master Aug 25, 2021
@zhiqwang zhiqwang deleted the onnx-output-info branch August 25, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code format and unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant