Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C3 following the model specification of YOLOv5 #343

Merged
merged 4 commits into from
Mar 6, 2022
Merged

Use C3 following the model specification of YOLOv5 #343

merged 4 commits into from
Mar 6, 2022

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Mar 6, 2022

The FPN implemented by TorchVision is a bit different from the PAN layers used by YOLOv5, it will result in 4 layers of output in head with C3 (YOLOv5 only has 3 layers as a comparison), maybe we can rewrite the BackboneWithFPN in the future following the YOLOv5's PAN.

@zhiqwang zhiqwang added the enhancement New feature or request label Mar 6, 2022
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #343 (6ee9f36) into main (b96c225) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 6ee9f36 differs from pull request most recent head 39b4342. Consider uploading reports for the commit 39b4342 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   95.46%   95.53%   +0.06%     
==========================================
  Files          11       11              
  Lines         771      783      +12     
==========================================
+ Hits          736      748      +12     
  Misses         35       35              
Flag Coverage Δ
unittests 95.53% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_models.py 96.06% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b96c225...39b4342. Read the comment docs.

@zhiqwang zhiqwang merged commit f229a08 into main Mar 6, 2022
@zhiqwang zhiqwang deleted the use-C3 branch March 6, 2022 04:23
zhiqwang added a commit that referenced this pull request Mar 8, 2022
* Use C3 following the model specification of YOLOv5

* Add unittest for yolov5_mobilenet_v3_small_fpn

* Add type annotations

* Minor fix for weights_name
zhiqwang added a commit that referenced this pull request Mar 8, 2022
* Use C3 following the model specification of YOLOv5

* Add unittest for yolov5_mobilenet_v3_small_fpn

* Add type annotations

* Minor fix for weights_name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant