Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bias initializations from private methods to constructors #351

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Mar 9, 2022

Follow upstream pytorch/vision#5331

@zhiqwang zhiqwang added the code quality Code format and unit tests label Mar 9, 2022
@CLAassistant
Copy link

CLAassistant commented Mar 9, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #351 (7270da6) into main (225759b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          11       11           
  Lines         781      781           
=======================================
  Hits          749      749           
  Misses         32       32           
Flag Coverage Δ
unittests 95.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225759b...7270da6. Read the comment docs.

@zhiqwang zhiqwang merged commit 0345ed6 into main Mar 9, 2022
@zhiqwang zhiqwang deleted the bias-initializations branch March 9, 2022 17:37
zhiqwang added a commit that referenced this pull request Mar 12, 2022
* Move bias initializations from private methods to constructors

* Cleanup header

* Fix docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code format and unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants