Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lightning dependencies #355

Merged
merged 5 commits into from
Mar 11, 2022
Merged

Remove lightning dependencies #355

merged 5 commits into from
Mar 11, 2022

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Mar 11, 2022 •
edited
Loading

As mentioned in #219 , if someone just wants to use the models for inference, he/she doesn't need all additional features like:

  • pytorch-lightning
  • torchmetrics

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zhiqwang zhiqwang added the dependencies Pull requests that update a dependency file label Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022 •
edited
Loading

Codecov Report

Merging #355 (655b6bf) into main (2ccfb66) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   98.57%   98.58%           
=======================================
  Files          11       11           
  Lines         773      776    +3     
=======================================
+ Hits          762      765    +3     
  Misses         11       11
Flag Coverage Δ
unittests 98.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_data_pipeline.py 100.00% <100.00%> (ø)
test/test_models_yolov5.py 100.00% <100.00%> (ø)
test/test_trainer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ccfb66...655b6bf. Read the comment docs.

@zhiqwang zhiqwang mentioned this pull request Mar 11, 2022
Open
6 tasks
@zhiqwang zhiqwang merged commit 9922f46 into main Mar 11, 2022
@zhiqwang zhiqwang deleted the remove-lightning branch March 11, 2022 12:51
@zhiqwang zhiqwang mentioned this pull request Mar 12, 2022
Merged
zhiqwang added a commit that referenced this pull request Mar 12, 2022
@zhiqwang
Remove lightning dependencies (#355)
7665821 
* Remove lightning dependencies

* Remove lightning dependencies in unittest

* Remove lightning dependencies in CLI tools

* Apply pre-commit

* Fix distribution names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiqwang @CLAassistant