Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ImportError of circular reference #369

Merged
merged 3 commits into from
Mar 16, 2022
Merged

Fix ImportError of circular reference #369

merged 3 commits into from
Mar 16, 2022

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Mar 16, 2022

Close #368

  • move load_from_ultralytics() into "yolort/models/_utils.py"
  • move contains_any_tensor() into "yolort/utils/__init__.py"

cc @mattpopovich

@zhiqwang zhiqwang added code quality Code format and unit tests dependencies Pull requests that update a dependency file labels Mar 16, 2022
@zhiqwang zhiqwang added bc-breaking Backwards Incompatible Changes bug / fix Something isn't working labels Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #369 (4260072) into main (9a27b91) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          11       11           
  Lines         776      778    +2     
=======================================
+ Hits          765      767    +2     
  Misses         11       11           
Flag Coverage Δ
unittests 98.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_data_pipeline.py 100.00% <100.00%> (ø)
test/test_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a27b91...4260072. Read the comment docs.

@zhiqwang zhiqwang merged commit 3c14e91 into main Mar 16, 2022
@zhiqwang zhiqwang deleted the cirular-import branch March 16, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc-breaking Backwards Incompatible Changes bug / fix Something isn't working code quality Code format and unit tests dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular reference caused by the load_from_ultralytics()
1 participant