Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64 Native Build For Windows #343

Closed
intzaaa opened this issue Mar 11, 2023 · 8 comments
Closed

Arm64 Native Build For Windows #343

intzaaa opened this issue Mar 11, 2023 · 8 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@intzaaa
Copy link
Contributor

intzaaa commented Mar 11, 2023

Windows computers with Arm SOC have a long battery life and now more and more people, especially teachers and students, are using these kind of computers and wnr is exactly what they need.
Thanks!

@roldanjr roldanjr added the enhancement New feature or request label Mar 11, 2023
@sekwah41
Copy link
Member

Sorry but github build actions do not currently support arm64 runners. Though I may be able to set up one of my raspberry pi’s or something to allow it. Though you will need to check what windows os you are using because certain versions can only use windows created executables.

I’ll need to see if the building tools support cross compiling. Luckily as I’ve been adding Tauri support we may have stuff there too.

@intzaaa
Copy link
Contributor Author

intzaaa commented Mar 12, 2023

I build pomatez successfully in wsl.
image

@intzaaa
Copy link
Contributor Author

intzaaa commented Mar 12, 2023

Just add arm64 to package.json and it just work!
Also see: https://github.com/huangyinhaow/pomatez-builds/releases/tag/latest

@sekwah41
Copy link
Member

sekwah41 commented Mar 12, 2023

Oh is this the windows 11 arm preview?

As long as we add something to the name so there isnt a name clash it should be all fine :D

Also was that on wsl also on a arm machine? I meant cross artitecture, because some systems can be a pain when it comes to building though I believe electron usually is the same info then just an internal asar file usually is whats switched out.

@intzaaa
Copy link
Contributor Author

intzaaa commented Mar 13, 2023

In your first comment, you expressed your concern about the feasibility of cross-compiling, so I first tried a method that does not require cross-compiling, i.e. compiling in wsl on arm64. This method can successfully build pomatez, but not NSIS, so building it requires using wine32, which is not possible on the arm64 platform.

Next, I tried the second method: build pomatez on github actions. I forked this repo, modified the /app/main/package.json to

    "win": {
      "target": [
        {
          "target": "portable",
          "arch": [
            "arm64"
          ]
        },
        {
          "target": "nsis",
          "arch": [
            "arm64"
          ]
        }
      ],

, and luckily, it worked perfectly.

Unfortunately, however, I'm just a programming beginner and I don't know much about package releases, so I don't really plan to make a PR, sorry!

@intzaaa
Copy link
Contributor Author

intzaaa commented Mar 13, 2023

Notification is not working.
https://user-images.githubusercontent.com/64564727/224655298-f5bd0ea1-f622-43f7-8801-767aa0bcace4.mp4

@sekwah41
Copy link
Member

sekwah41 commented May 2, 2023

Need to take more of a look, just been quite busy lately though there is also more news about Microsoft and arm now so I will need to take more of a look.

@roldanjr roldanjr self-assigned this May 11, 2023
@roldanjr roldanjr added the bug Something isn't working label May 11, 2023
@roldanjr roldanjr removed their assignment May 11, 2023
pdax-roldan pushed a commit that referenced this issue May 12, 2023
@intzaaa
Copy link
Contributor Author

intzaaa commented May 14, 2023

Done in #376 .

roldanjr added a commit that referenced this issue Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants