refactor(renderer): extract common logic from Electron and Tauri connectors #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My plan at least is to eventually drop electron support once we have everything ported over (and it supports everything equally) solely to reduce the amount of maintenance. I think the only thing that would suffer from it is the portable version however windows comes with most of the stuff pre-installed it requires at least so technically you can still sorta have a portable version. Tho not to the same degree as Electron. |
|
I'm closing this for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a refactor of the Tauri and Electron connectors.
I created an
AgnosticConnectorcomponent to store the common code of both components.The idea is to introduce in the AgnosticConnector the logic to manage global shortcuts (PR incoming)