Fixed typo - "Stay focus" #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekwah41
approved these changes
Jan 23, 2024
|
Hey, sorry though a large pr was just merged that needed reviewing for a few weeks, could you possibly refactor your changes on top of the new master branch? |
|
@sekwah41 Done. |
sekwah41
approved these changes
Mar 13, 2024
sekwah41
requested changes
Mar 15, 2024
| @@ -50,9 +50,9 @@ const CounterProvider: React.FC = ({ children }) => { | |||
|
|
|||
| const [shouldFullscreen, setShouldFullscreen] = useState(false); | |||
|
|
|||
| const [count, setCount] = useState(config.stayFocus * 60); | |||
There was a problem hiding this comment.
You can change the litteral translations but can you revert the variables. The issue is that these are stored as a json so it means the settings don't work/exist and result in an NAN for existing users
|
To change the stay-focused variable itself, we'd need to load it from both the old naming and the new naming to allow it to transition users over slowly. While its an option its a small price to pay for a value users will never see. |
Variable names have been reverted to pre-49941a16.
|
@sekwah41 Fixed. |
|
Sorry for the delay, ill take a look at this tomorrow ^.^ |
sekwah41
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several locations, the app uses the phrase "Stay focus," which should say "Stay focused" (grammatical error). The commit in this pull request resolves the issue.
For clarity, the names of variables and functions that use the words "stay" and "focus" have also been updated.