Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scrollbar #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: scrollbar #87

wants to merge 1 commit into from

Conversation

0xshodan
Copy link

Pull request for scrollbar feature #5

@0xshodan 0xshodan changed the title scrollbar feat: scrollbar Aug 1, 2023
zifeo
zifeo reviewed Aug 1, 2023
View reviewed changes
Copy link
Owner

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation! Two weird behaviour:

  1. It seems the tab only show when there is space for 2 spaces
image
  1. One can select the "..." as a tab
image

src/actors/console.rs
let mut counter: usize = 0;
let mut ret: Vec<String> = Vec::new();
let mut width = (self.width - (BORDER_LENGTH * 2)) as usize;
let mut r = 0;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is r required or i can be used to return?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zifeo zifeo zifeo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
update needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xshodan @zifeo