Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove CompileStep.output_dir from the build system API #14951

Closed
Tracked by #14647
andrewrk opened this issue Mar 16, 2023 · 0 comments · Fixed by #15234
Closed
Tracked by #14647

remove CompileStep.output_dir from the build system API #14951

andrewrk opened this issue Mar 16, 2023 · 0 comments · Fixed by #15234
Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. zig build system std.Build, the build runner, `zig build` subcommand, package management
Milestone
0.11.0

Comments

@andrewrk
Copy link
Member

Extracted from #14647.

This field must be deleted:

zig/lib/std/Build/CompileStep.zig

Line 106 in b4d58e9

output_dir: ?[]const u8,

Build scripts must use the FileSource abstraction rather than telling the compiler directly where to output files.
@andrewrk andrewrk added breaking Implementing this issue could cause existing code to no longer compile or have different behavior. zig build system std.Build, the build runner, `zig build` subcommand, package management labels Mar 16, 2023
@andrewrk andrewrk added this to the 0.11.0 milestone Mar 16, 2023
This was referenced Mar 17, 2023
Merged
Closed
andrewrk added a commit that referenced this issue Apr 10, 2023
@andrewrk
std.Build.CompileStep: remove output_dir
7ac6d60 
Build scripts must instead use the FileSource abstraction rather than
telling the compiler directly where to output files.

closes #14951
@andrewrk andrewrk mentioned this issue Apr 10, 2023
Merged
andrewrk added a commit that referenced this issue Apr 11, 2023
@andrewrk
std.Build.CompileStep: remove output_dir
19ef5b0 
Build scripts must instead use the FileSource abstraction rather than
telling the compiler directly where to output files.

closes #14951
andrewrk added a commit that referenced this issue Apr 11, 2023
@andrewrk
std.Build.CompileStep: remove output_dir
5a8b1bd 
Build scripts must instead use the FileSource abstraction rather than
telling the compiler directly where to output files.

closes #14951
krichprollsch added a commit to lightpanda-io/zig-v8-fork that referenced this issue Sep 8, 2023
@krichprollsch
build: 0.11: remove output_dir
f72e6a8 
see ziglang/zig#14951
krichprollsch added a commit to lightpanda-io/zig-v8-fork that referenced this issue Sep 12, 2023
@krichprollsch
build: 0.11: remove output_dir
ef481a6 
see ziglang/zig#14951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Implementing this issue could cause existing code to no longer compile or have different behavior. zig build system std.Build, the build runner, `zig build` subcommand, package management
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

remove --enable-cache option; std.Build.CompileStep: remove output_dir ziglang/zig
1 participant
@andrewrk