Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/standalone/emit_asm_and_bin and issue_12588 can be re-enabled now #17484

Closed
andrewrk opened this issue Oct 11, 2023 · 0 comments
Closed

test/standalone/emit_asm_and_bin and issue_12588 can be re-enabled now #17484

andrewrk opened this issue Oct 11, 2023 · 0 comments
Labels
bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals.
Milestone
0.14.0

Comments

@andrewrk
Copy link
Member

zig/test/standalone.zig

Lines 143 to 152 in 5722261

// TODO take away EmitOption.emit_to option and make it give a FileSource
//.{
// .build_root = "test/standalone/emit_asm_and_bin",
// .import = @import("standalone/emit_asm_and_bin/build.zig"),
//},
// TODO take away EmitOption.emit_to option and make it give a FileSource
//.{
// .build_root = "test/standalone/issue_12588",
// .import = @import("standalone/issue_12588/build.zig"),
//},

These were waiting for a LazyPath reckoning, which has happened in #16446 thanks to @MasterQ32. Now these tests can be enabled.

The one called "issue_12588" should be renamed to describe what it is testing instead of named after a GitHub:tm: issue.
@andrewrk andrewrk added bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. labels Oct 11, 2023
@andrewrk andrewrk added this to the 0.13.0 milestone Oct 11, 2023
maximest-pierre added a commit to maximest-pierre/zig that referenced this issue Oct 23, 2023
@maximest-pierre
test: ziglang#17484 reenable emit asm and bin and rename issue_12588 …
7731c6e 
…test
@maximest-pierre maximest-pierre mentioned this issue Oct 23, 2023
Closed
Parzival-3141 added a commit to Parzival-3141/zig that referenced this issue Feb 17, 2024
@Parzival-3141
reenable tests and rename standalone/issue_12588
e18b878 
Closes ziglang#17484
@Parzival-3141 Parzival-3141 mentioned this issue Feb 17, 2024
Closed
Snektron added a commit to Snektron/zig that referenced this issue Aug 18, 2024
@Snektron
re-enable emit_asm_and_bin and emit_llvm_no_bin tests
5ae56c4 
These were fixed during the last few commits too. The emit_llvm_no_bin test
is renamed from the issue_12588 test.

Closes ziglang#17484
Snektron added a commit to Snektron/zig that referenced this issue Aug 18, 2024
@Snektron
re-enable emit_asm_and_bin and emit_llvm_no_bin tests
db99ec3 
These were fixed during the last few commits too. The emit_llvm_no_bin test
is renamed from the issue_12588 test.

Closes ziglang#17484
Snektron added a commit to Snektron/zig that referenced this issue Aug 18, 2024
@Snektron
re-enable emit_asm_and_bin and emit_llvm_no_bin tests
b3f638c 
These were fixed during the last few commits too. The emit_llvm_no_bin test
is renamed from the issue_12588 test.

Closes ziglang#17484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals.
Projects
None yet
Milestone
0.14.0
1 participant
@andrewrk