Nuke the C++ implementation of Zig from orbit using WASI #13560

After this commit, the self-hosted compiler does not offer the option to use stage1 as a backend anymore.

Also, make -Donly-c prevent Autodoc from being included in the binary. This produces a 2.6 MiB zig.wasm file. 781 KB if piped through zstd.

These functions had a compile error since the introduction of IterableDir.

In theory this will enhance the performance of interpreting a WASI build of Zig.

Instead of checking for absolute paths and current working directories in various file system operations, there is one simple solution: allow overriding `std.fs.cwd` on WASI. os.realpath is back to causing a compile error when used on WASI. This caused a compile error in the Sema handling of `@src()`. The compiler should never call realpath, so the commit that made this change is reverted (95ab942). If this breaks debug info, a different strategy is needed to solve it other than using realpath. I also removed the preopens code and replaced it with something much simpler. There is no longer any global state in the standard library. Additionally- * os.openat no longer does an unnecessary fstat on WASI when O.WRONLY is not provided. * os.chdir is back to causing a compile error on WASI.

current status is that it hits error: OutOfMemory for unknown reasons, probably due to bugs in the C WASI interpreter port.

* synchronize zig1.c from zig-wasi external project * change the way argv works to avoid absolute paths * autodetect isatty * compiler_rt: disable some functions when object format is C * add missing flag from config.zig.in The next problem is that compiling compiler_rt.c with gcc gives "conflicting types" errors for `__eqhf2` and friends.

only the decompression files

This takes a bit longer since the interpreted part has to do more work but it saves a round trip through the compiler by allowing `zig2 build` to be the final step. 1-2-3, done. For me this is currently failing due to compilation errors generated by GCC when compiling zig2.c but in theory if those are fixed, it should work!

instead of assuming x8_64-linux in CMake

Idea here is that this is a sweet spot of not wasting time waiting for optimizations but also getting decent runime performance.

* Remove usage of O_PATH, ifdef for macos stat struct, and integer formatting

This is a workaround for a limitation of the C backend.

Now that OOM is no longer a problem, the Windows CI can do the same process every other system does instead of building from a recent Zig binary.

This was set on accident.

Now it is a single command tdo update zig1.wasm.zst.

When producing C source code. This enables strip, which should avoid bloat and save compilation time.

The way this is implemented destroys the contents of the file, so revisit if this causes issues in the future.

This avoids the need to pass `-fbracket-depth=512` to clang.

This flag makes CI servers print garbage to the terminal. I started implementing detection in wasi.c, but it would have destroyed the beautiful code that only touches the C stdlib, does not do any conditional compilation based on the operating system, or rely on any POSIX functions. So instead, let's just do without this flag to retain simplicity in this step of the build process.

In ea9ad1e, I incorrectly applied boolean logic to one of the pieces of logic, resulting in a regression in translate-c.

This branch largely reverts 58f961f. I would like to revisit the proposal to modify the standard library in this way and think more carefully about it before adding isAbsolute() checks everywhere.

Before it was checking if the compiler was AppleClang, however, this did not handle the case when using a compiled-from-source Clang on a macOS computer, in which case the linker is still Apple ld64, and it is in fact the linker that needs to have the different flag to communicate stack size.

This change has been extracted to #13786 and can be solved separately than this branch.

Missing change from bcd4ea9

In the CI system, I copied the old tarball and then applied 05c21a2 to its compiler_rt implementation. After this is verified we can drop this commit and regenerate the tarballs from a master branch commit.

In particular, these two changes are relevant: * zig cc: support -stack in addition to --stack for linker arg - Fixes stack overflow when running zig2 on aarch64-macos. * compiler_rt: avoid using weak aliases - Fixes duplicate symbol when linking zig2 on aarch64-linux.

I messed up the spelling of '-stack_size' making it '-stack' instead. Will need to fix on master branch. But let's test this here before making another master branch commit.

On windows we get: lld-link: error: undefined symbol: __stack_chk_fail >>> referenced by CMakeFiles/zig2.dir/zig2.c.obj:(main) >>> referenced by CMakeFiles/zig2.dir/zig2.c.obj:(main_main) >>> referenced by CMakeFiles/zig2.dir/zig2.c.obj:(log_scoped_28_default_29_err__anon_2764) >>> referenced 36192 more times lld-link: error: undefined symbol: __stack_chk_guard >>> referenced by CMakeFiles/zig2.dir/zig2.c.obj:(.refptr.__stack_chk_guard) >>> referenced by CMakeFiles/zig2.dir/compiler_rt.c.obj

This commit chickens out and reverts 02456a3, leaving it for a future enhancement.

This commit adds a 637 KB binary file to the source repository. This commit does nothing else, so it should be replaced with a different commit before this branch is merged to avoid bloating the git repository.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nuke the C++ implementation of Zig from orbit using WASI #13560

Nuke the C++ implementation of Zig from orbit using WASI #13560

Commits on Dec 6, 2022