Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linxura smart controller button quirk #3392

Open
wants to merge 59 commits into
base: dev
Choose a base branch
from

Conversation

simon3panda
Copy link

@simon3panda simon3panda commented Sep 30, 2024

Proposed change

This PR adds a new quirk for the Linxura smart controller's Zigbee mode, enabling Linxura smart controller proper communication and control within the ZHA framework. Linxura smart controller's Zigbee mode support four Zigbee buttons. Each button support click, double click, long press actions.

Additional information

Test file is in tests/test_linxura.py

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

simon3panda and others added 3 commits September 23, 2024 15:40
Linxura smart controller's Zigbee mode support four buttons. Each button support click, double click, long press actions.
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.76%. Comparing base (d9c9df9) to head (e12e9df).
Report is 15 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/linxura/__init__.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3392      +/-   ##
==========================================
+ Coverage   88.49%   88.76%   +0.26%     
==========================================
  Files         305      308       +3     
  Lines        9621     9851     +230     
==========================================
+ Hits         8514     8744     +230     
  Misses       1107     1107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the new quirk Adds support for a new device label Oct 8, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please remove the commented out code.

@simon3panda
Copy link
Author

Thanks for the PR. Please remove the commented out code.
Thank you for reviewing the code, the comment code has been removed!

@linxura1
Copy link

@TheJulianJES Can you please merge this pull request? Thanks!

@simon3panda
Copy link
Author

Thanks for the PR. Please remove the commented out code.

Hi Julian, I've uploaded the code that removed commented part, is there anything I need to do before merge?

@TheJulianJES
Copy link
Collaborator

Have a bit of patience please. The PR needs to be reviewed properly. That'll be done when one of us has some free time.

@TheJulianJES TheJulianJES changed the title Add new quirks that support Linxura smart controller. Add Linxura smart controller button quirk Oct 16, 2024
@simon3panda
Copy link
Author

Have a bit of patience please. The PR needs to be reviewed properly. That'll be done when one of us has some free time.

Sure!Thank you for your quick feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quirk Adds support for a new device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants