-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linxura smart controller button quirk #3392
base: dev
Are you sure you want to change the base?
Conversation
Linxura smart controller's Zigbee mode support four buttons. Each button support click, double click, long press actions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3392 +/- ##
==========================================
+ Coverage 88.49% 88.76% +0.26%
==========================================
Files 305 308 +3
Lines 9621 9851 +230
==========================================
+ Hits 8514 8744 +230
Misses 1107 1107 ☔ View full report in Codecov by Sentry. |
modify spell issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Please remove the commented out code.
|
@TheJulianJES Can you please merge this pull request? Thanks! |
Hi Julian, I've uploaded the code that removed commented part, is there anything I need to do before merge? |
Have a bit of patience please. The PR needs to be reviewed properly. That'll be done when one of us has some free time. |
Sure!Thank you for your quick feedback. |
Proposed change
This PR adds a new quirk for the Linxura smart controller's Zigbee mode, enabling Linxura smart controller proper communication and control within the ZHA framework. Linxura smart controller's Zigbee mode support four Zigbee buttons. Each button support click, double click, long press actions.
Additional information
Test file is in tests/test_linxura.py
Checklist
pre-commit
checks pass / the code has been formatted using Black