Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OTA frame control fields #961

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Apr 13, 2022

Fixes #960

@coveralls
Copy link

coveralls commented Apr 13, 2022

Coverage Status

Coverage increased (+0.002%) to 99.738% when pulling b3591af on puddly:puddly/ota-schema-fixes into 3857bfe on zigpy:dev.

@TheJulianJES
Copy link
Contributor

Not sure if this PR is finished/tested, but it looks like the following errors appear in the log:

2022-04-13 20:07:11 WARNING (MainThread) [zigpy.util] Error calling listener.cluster_command: 'query_next_image' object is not subscriptable
2022-04-13 20:07:11 ERROR (MainThread) [zigpy.zcl] [0xA0E1:11:0x0019] Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/zigpy/zcl/clusters/general.py", line 1534, in _handle_cluster_request
await self._handle_query_next_image(
TypeError: zigpy.zcl.clusters.general.Ota._handle_query_next_image() argument after * must be an iterable, not query_next_image

@TheJulianJES
Copy link
Contributor

Seems to work properly now! Thanks puddly

@MattWestb
Copy link
Contributor

Is this also fixing IKEA OTA that also is broken 2022.4.X (I think so then its standard Zigbee commands) ?

And next i think its one large thing so it shall being released with HA bug fix so user dont need waiting to next HA major release for updating there devices (some user with old firmware is having problem with quirk not working then we have not fixing 100% for old firmware quirks and cant testing the old firmware then cant firmware downgrading the devices).

Thanks for great work with ZCLR 7.5 and all fixes done for getting all thing working !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Hue) OTA updates seemingly broken
4 participants