Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to react v18 #119

Merged
merged 4 commits into from
Nov 22, 2022
Merged

upgrade to react v18 #119

merged 4 commits into from
Nov 22, 2022

Conversation

shanghaikid
Copy link
Collaborator

@shanghaikid shanghaikid commented Nov 12, 2022 •
edited
Loading

  • upgrade react to v18
  • upgrade react-router-dom to v6
  • discard these plugin routers
  • fix broken page items search by url

@shanghaikid shanghaikid changed the title V18 upgrade to react v18 Nov 12, 2022
@shanghaikid shanghaikid marked this pull request as ready for review November 19, 2022 03:10
nameczz
nameczz requested changes Nov 22, 2022
View reviewed changes
client/src/pages/collections/Collections.tsx Outdated
}, [classes.highlight, classes.link, search, searchedCollections]);
}, [search, collections]);

console.log('render collections');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console

@nameczz nameczz merged commit 937d997 into main Nov 22, 2022
@nameczz nameczz deleted the v18 branch November 22, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nameczz nameczz nameczz requested changes

@Tumao727 Tumao727 Awaiting requested review from Tumao727

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanghaikid @nameczz