Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arm64 support & bump actions #277

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

keongalvin
Copy link
Contributor

@keongalvin keongalvin commented Sep 23, 2023

As Milvus support arm64 images, this PR attempts to add the same capability for attu.

Some caveats

@shanghaikid shanghaikid merged commit b707c69 into zilliztech:main Sep 25, 2023
1 check passed
@shanghaikid
Copy link
Collaborator

Since it is failed to run, I just reverted this change.
https://github.com/zilliztech/attu/actions/runs/6298549196

@kish5430
Copy link

HI Team,

Can you please proved ETA to release the Attu version to support ARM.

Thanks

@shanghaikid
Copy link
Collaborator

HI Team,

Can you please proved ETA to release the Attu version to support ARM.

Thanks

The current docker image runs on my macbook m1 perfectly, which ARM platform are you using?

@kish5430
Copy link

kish5430 commented Feb 29, 2024

HI Team,
Can you please proved ETA to release the Attu version to support ARM.
Thanks

The current docker image runs on my macbook m1 perfectly, which ARM platform are you using?

We are using AWS ARM-based instance

@shanghaikid
Copy link
Collaborator

HI Team,
Can you please proved ETA to release the Attu version to support ARM.
Thanks

The current docker image runs on my macbook m1 perfectly, which ARM platform are you using?

We are using AWS ARM.

does it work? do you see any specific errors? Actually attu is just an node application.

@kish5430
Copy link

HI Team,
Can you please proved ETA to release the Attu version to support ARM.
Thanks

The current docker image runs on my macbook m1 perfectly, which ARM platform are you using?

We are using AWS ARM.

does it work? do you see any specific errors? Actually attu is just an node application.

It was not working. Unfortunately i didn't capture the logs.

@shanghaikid
Copy link
Collaborator

HI Team,
Can you please proved ETA to release the Attu version to support ARM.
Thanks

The current docker image runs on my macbook m1 perfectly, which ARM platform are you using?

We are using AWS ARM.

does it work? do you see any specific errors? Actually attu is just an node application.

It was not working. Unfortunately i didn't capture the logs.

I will create a Node ARM image using a common approach and upload it to Docker Hub, probably next week. I'm quite busy this week. I will let you know when it is ready.

@kish5430
Copy link

HI Team,
Can you please proved ETA to release the Attu version to support ARM.
Thanks

The current docker image runs on my macbook m1 perfectly, which ARM platform are you using?

We are using AWS ARM.

does it work? do you see any specific errors? Actually attu is just an node application.

It was not working. Unfortunately i didn't capture the logs.

I will create a Node ARM image using a common approach and upload it to Docker Hub, probably next week. I'm quite busy this week. I will let you know when it is ready.

Sure @shanghaikid ....Thanks

@shanghaikid
Copy link
Collaborator

HI Team,
Can you please proved ETA to release the Attu version to support ARM.
Thanks

The current docker image runs on my macbook m1 perfectly, which ARM platform are you using?

We are using AWS ARM.

does it work? do you see any specific errors? Actually attu is just an node application.

It was not working. Unfortunately i didn't capture the logs.

I will create a Node ARM image using a common approach and upload it to Docker Hub, probably next week. I'm quite busy this week. I will let you know when it is ready.

Sure @shanghaikid ....Thanks

We have released arm image on the dev channel, you can have a try.
image

@kish5430
Copy link

kish5430 commented Mar 5, 2024

HI Team,

I have deployed Attu pod with dev version. But still its not supporting and giving below error.

$ kubectl logs milvus-attu-5cc84674b7-zpjmm -n isds-milvus
exec /usr/local/bin/docker-entrypoint.sh: exec format error

Thanks

@shanghaikid
Copy link
Collaborator

HI Team,

I have deployed Attu pod with dev version. But still its not supporting and giving below error.

$ kubectl logs milvus-attu-5cc84674b7-zpjmm -n isds-milvus exec /usr/local/bin/docker-entrypoint.sh: exec format error

Thanks

ok, we will try to fix it, thanks for the support.

@zhanshuyou
Copy link
Contributor

zhanshuyou commented Mar 6, 2024

@kish5430 Can you provide more information?

Check what platform your AKS cluster supports:
kubectl describe node | grep "kubernetes.io/arch"

Check what platform your Dockerfile supports:
docker buildx ls

I'm not sure if this article can help you.
https://medium.com/@yvonne.radsmikham/docker-exec-bin-sh-exec-format-error-on-arm64-112ccf2df941

@kish5430
Copy link

kish5430 commented Mar 6, 2024

@zhanshuyou Plz find below details.

$ kubectl describe node | grep "kubernetes.io.arch"
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64
Labels: beta.kubernetes.io/arch=arm64
kubernetes.io/arch=arm64

===================================================

$ docker buildx ls
NAME/NODE DRIVER/ENDPOINT STATUS BUILDKIT PLATFORMS
default * docker
default default running 20.10.21 linux/amd64, linux/arm64, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/arm/v7, linux/arm/v6
desktop-linux docker
desktop-linux desktop-linux running 20.10.21 linux/amd64, linux/arm64, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/arm/v7, linux/arm/v6
Thanks

@zhanshuyou
Copy link
Contributor

@kish5430
Did you pull the image using the command below?
docker pull --platform linux/arm64 zilliz/attu:dev

@kish5430
Copy link

kish5430 commented Mar 6, 2024

@kish5430 Did you pull the image using the command below? docker pull --platform linux/arm64 zilliz/attu:dev

@zhanshuyou we used below image tag in yaml file to deploy the attu. But still getting same issue
image: zilliz/attu:dev

Error:
$ kubectl logs milvus-attu-6f7885867f-fktqv -n isds-milvus
exec /usr/local/bin/docker-entrypoint.sh: exec format error

@zhanshuyou
Copy link
Contributor

@keongalvin
Can you check the architecture of the image?
docker inspect {imageId} | grep Architecture

@zhanshuyou
Copy link
Contributor

Or you can try adding the platform parameter.
image

@kish5430
Copy link

kish5430 commented Mar 7, 2024

@zhanshuyou platform key is not available and got below error.
Error from server (BadRequest): error when creating "attu-deploy.yaml": Deployment in version "v1" cannot be handled as a Deployment: strict decoding error: unknown field "spec.template.spec.containers[0].platform"

@zhanshuyou
Copy link
Contributor

@keongalvin Can you check the architecture of the image? docker inspect {imageId} | grep Architecture

Do you check the architecture of the image

@kish5430
Copy link

@keongalvin Can you check the architecture of the image? docker inspect {imageId} | grep Architecture

Do you check the architecture of the image

It was showing 'arm64' when downloaded onto the local machine. But it's not working when I use this for an image tag in Yaml.

@zhanshuyou
Copy link
Contributor

@keongalvin Can you check the architecture of the image? docker inspect {imageId} | grep Architecture

Do you check the architecture of the image

It was showing 'arm64' when downloaded onto the local machine. But it's not working when I use this for an image tag in Yaml.

Can you show me the deploy Yaml?

@kish5430
Copy link

kish5430 commented Mar 12, 2024

@keongalvin Can you check the architecture of the image? docker inspect {imageId} | grep Architecture

Do you check the architecture of the image

It was showing 'arm64' when downloaded onto the local machine. But it's not working when I use this for an image tag in Yaml.

Can you show me the deploy Yaml?

Please check below attu deployment yaml
apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app: attu
name: milvus-attu
namespace: isds-milvus
spec:
replicas: 1
selector:
matchLabels:
app: attu
template:
metadata:
labels:
app: attu
spec:
containers:
- env:
- name: MILVUS_URL
value: xxxxxxxx
image: zilliz/attu:dev
imagePullPolicy: IfNotPresent
name: attu
ports:
- containerPort: 3000
name: attu
protocol: TCP
restartPolicy: Always

@kish5430
Copy link

@keongalvin Can you check the architecture of the image? docker inspect {imageId} | grep Architecture

Do you check the architecture of the image

It was showing 'arm64' when downloaded onto the local machine. But it's not working when I use this for an image tag in Yaml.

Can you show me the deploy Yaml?

Please check below attu deployment yaml apiVersion: apps/v1 kind: Deployment metadata: labels: app: attu name: milvus-attu namespace: isds-milvus spec: replicas: 1 selector: matchLabels: app: attu template: metadata: labels: app: attu spec: containers: - env: - name: MILVUS_URL value: xxxxxxxx image: zilliz/attu:dev imagePullPolicy: IfNotPresent name: attu ports: - containerPort: 3000 name: attu protocol: TCP restartPolicy: Always

HI @zhanshuyou ,
Did you validate the yaml ?

@zhanshuyou
Copy link
Contributor

zhanshuyou commented Mar 14, 2024

@kish5430
You can pull the latest zilliz/attu:dev image.
image

@kish5430
Copy link

@kish5430 You can pull the latest image. image

HI @zhanshuyou
I tried again, still getting the same issue.

$ kubectl logs milvus-attu-5c57bc7d59-2l589 -n isds-milvus
exec /usr/local/bin/docker-entrypoint.sh: exec format error

Thanks

@kish5430
Copy link

@kish5430 You can pull the latest image. image

HI @zhanshuyou I tried again, still getting the same issue.

$ kubectl logs milvus-attu-5c57bc7d59-2l589 -n isds-milvus exec /usr/local/bin/docker-entrypoint.sh: exec format error

Thanks

HI @zhanshuyou

It is picking the arm image when we add sha256 as below, and it is working fine.
image: zilliz/attu:dev@sha256:a580f7547ffc9019408058187e0877ddb5b2c3752437b54cc604d25d601fdb30

Thanks

@zhanshuyou
Copy link
Contributor

@kish5430 You can pull the latest image. image

HI @zhanshuyou I tried again, still getting the same issue.

$ kubectl logs milvus-attu-5c57bc7d59-2l589 -n isds-milvus exec /usr/local/bin/docker-entrypoint.sh: exec format error

Thanks

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants