Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attu-384: refactor for performance #425

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Attu-384: refactor for performance #425

merged 8 commits into from
Mar 8, 2024

Conversation

shanghaikid
Copy link
Collaborator

The showCollections api doesn't return lots of useful information, we need to fetch lots api for a single collection, it makes attu unusable if you have a lot collections.

This pr includes:

  • use single source of truth in the client side, so that no more fetches all collections between pages
  • only update target collection's data if loading or indexing
  • only fetch all loaded collections or 5 collections with detail information at most, then the rest of collections will be fetched and sent to the client later by batch with websocket
  • bug fixes and code clean

performance result:

  • get 40 collections, 2s+ vs 50s+ (tested on milvus v.2.3.10)

This pr should fix #393 and resolve #384 and fix #338

shanghaikid and others added 8 commits March 5, 2024 19:01
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ruiyi.jiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
@shanghaikid shanghaikid merged commit 6fe7d9a into main Mar 8, 2024
1 check passed
@shanghaikid shanghaikid deleted the task branch March 8, 2024 08:09
@shanghaikid shanghaikid mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Collections loading slow Redesign and Refactor It takes very long time to show index info.
1 participant