If screenshot is within tolerance do not update reference image #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertogasparin
force-pushed
the
avoid-reference-rewrite
branch
from
a154368
to
1a87cef
Compare
zinserjan
requested changes
Jan 12, 2017
| @@ -127,7 +127,7 @@ describe('LocalCompare', function () { | |||
|
|
|||
| // check if reference was updated | |||
There was a problem hiding this comment.
Can you please update the comments in Line 118, 128 & 195?
albertogasparin
force-pushed
the
avoid-reference-rewrite
branch
from
1a87cef
to
921578c
Compare
zinserjan
approved these changes
Jan 13, 2017
|
I just merged it with another breaking change for firefox and released it as v0.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the reference images after every passed test was causing Git to flag them as changed (even if the mismatch tolerance was 0%).
Closes #32