Add Resource.toManagedZIO, add Concurrent.continual implementation, fix toManaged #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
neko-kai
commented
Nov 16, 2019
neko-kai
commented
- remove unused Util.fromFuture – superseded by ZIO.fromFuture
- remove redundant accessM/provide in Concurrent.cancelable
- remove redundant private classes CatsMonad & CatsEffect
- Fix Exit/ExitCase handling in toManaged/toResource - new makeCase/makeExit clauses in CatZManagedSyntaxSpec didn't pass before
- minor code cleanups
…ix toManaged * remove unused Util.fromFuture – superseded by ZIO.fromFuture * remove redundant accessM/provide in Concurrent.cancelable * remove redundant private classes CatsMonad & CatsEffect * Fix Exit/ExitCase handling in toManaged/toResource - new makeCase/makeExit clauses in CatZManagedSyntaxSpec didn't pass before * minor code cleanups
iravid
previously approved these changes
Nov 17, 2019
| @@ -26,6 +25,14 @@ class CatsZManagedSyntaxSpec extends Specification with AroundTimeout with Defau | |||
| calls finalizers should not run if exception is thrown in acquisition $toManagedFinalizersExceptionAcquisition | |||
| composing with other managed should calls finalizers in correct order $toManagedComposition | |||
|
|
|||
| toManagedZIO | |||
There was a problem hiding this comment.
Great to see the additional coverage!
| fa.ensuring(finalizer.orDie) | ||
|
|
||
| override final def continual[A, B](fa: RIO[R, A])(f: Either[Throwable, A] => RIO[R, B]): RIO[R, B] = | ||
| ZIO.uninterruptibleMask(_(fa).either.flatMap(f)) |
There was a problem hiding this comment.
Yes, I think this is correct from inspecting the implementation of Concurrent.continual. I thought at first that f shouldn't run uninterruptibly, but in Concurrent.continual it is executed under guaranteeCase which (I assume) runs a finalizer uninterruptibly.
| }) | ||
| .uninterruptible | ||
| ) | ||
| ZManaged(L.liftIO(res.map { |
| final class CatsIOResourceSyntax[F[_], A](private val resource: Resource[F, A]) extends AnyVal { | ||
|
|
||
| def toManagedZIO[R, E <: Throwable](implicit ev: Resource[F, A] <:< Resource[ZIO[R, E, ?], A]): ZManaged[R, E, A] = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.