Update FS2 and attempt optimizations to FS2 -> ZStream conversion logic #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinlfer
commented
Nov 13, 2021
zio-interop-cats/shared/src/main/scala/zio/stream/interop/FS2StreamSyntax.scala
Outdated
Show resolved
Hide resolved
calvinlfer
commented
Nov 13, 2021
zio-interop-cats/shared/src/main/scala/zio/stream/interop/FS2StreamSyntax.scala
Outdated
Show resolved
Hide resolved
…ing the FS2 stream & matching on each subtype of the fs2.Chunk to attempt conversion to a proper ZIO counterpart
…lementations of queue sizes
|
hey @adamgfraser @neko-kai can y'all please have a look when y'all have some time? |
adamgfraser
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update FS2 integration logic and make optimizations to avoid re-chunking the FS2 stream (by dropping down to fs2's Pull to access the existing chunked structure) & matching on each subtype of the fs2.Chunk to attempt conversion to a proper ZIO counterpart