Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen Error Type to Throwable in ZIO Test Interop #70

Merged
merged 1 commit into from
Sep 22, 2019
Merged

Widen Error Type to Throwable in ZIO Test Interop #70

merged 1 commit into from
Sep 22, 2019

Conversation

adamgfraser
Copy link
Contributor

When we originally implemented the interop support for ZIO Test, the test methods required the error type to be Nothing, so we translated any Throwable in the F effect to a die failure using orDie. Subsequently we made the test methods in ZIO Test polymorphic in the error type, so now we can stop doing that and just propagate the potential Throwable failure through.

Copy link
Member

@neko-kai neko-kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghostdogpr ghostdogpr merged commit 314e17e into zio:master Sep 22, 2019
@adamgfraser adamgfraser deleted the test branch September 22, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants