Change referencing super.prepare call to this.prepare in quill-cassandra contexts
#1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be called otherwise
mosyp
changed the title
super.prepare call to this.prepare in quill-cassandra contexts
|
Thanks! any plans of creating a new release? |
|
@ayushworks Sure, However I'm about to finish #987 so we could release |
|
@ayushworks However if you need it know you could use snapshot version |
|
Thanks @mentegy !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
executeQuery and executeAction in CassandraAsyncContext and CassandraSessionContext classes are calling super.prepare. This will not allow any overriden implementation of prepare to be called.
Solution
Call prepare method using this and not using super
@getquill/maintainers