Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change referencing super.prepare call to this.prepare in quill-cassandra contexts #1067

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

ayushworks
Copy link
Contributor

Problem

executeQuery and executeAction in CassandraAsyncContext and CassandraSessionContext classes are calling super.prepare. This will not allow any overriden implementation of prepare to be called.

Solution

Call prepare method using this and not using super

@getquill/maintainers

Copy link
Collaborator

@mosyp mosyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mosyp mosyp changed the title call prepare using this and not super Change referencing super.prepare call to this.prepare in quill-cassandra contexts Apr 6, 2018
@mosyp mosyp merged commit 024aae8 into zio:master Apr 6, 2018
@ayushworks
Copy link
Contributor Author

Thanks! any plans of creating a new release?

@mosyp
Copy link
Collaborator

mosyp commented Apr 6, 2018

@ayushworks Sure, However I'm about to finish #987 so we could release 2.4.

@mosyp
Copy link
Collaborator

mosyp commented Apr 6, 2018

@ayushworks However if you need it know you could use snapshot version 2.3.4-SNAPSHOT

@ayushworks
Copy link
Contributor Author

Thanks @mentegy !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants