Drop Java 8 support && Introduce Java21 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
commented
Sep 23, 2023
| @@ -29,8 +28,8 @@ jobs: | |||
| - name: Setup Scala | |||
| uses: actions/[email protected] | |||
| with: | |||
| distribution: temurin | |||
| java-version: '8' | |||
| distribution: corretto | |||
There was a problem hiding this comment.
temurin didn't publish their version of Java 21 yet
1 task
adamgfraser
approved these changes
Sep 24, 2023
|
Thanks for the clear and concise answer @adamgfraser 😄🙏 |
|
A nice move! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows zio/zio#8434
We were emitting Java8 bytecode, not we generate Java11 bytecode.
See https://github.com/zio/zio-sbt/pull/296/files#diff-bf3171487bdb6bd0654f0cdda719dffd49d5f9f7aabd2bfacdfc5f20588ddea9R161
Asked the question to @jdegoes and @adamgfraser if they were okay with this change here: https://x.com/guizmaii/status/1705963927710941321?s=20
Waiting for answer 🙂