Unify java versions #399
Merged
Unify java versions #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
reviewed
May 27, 2024
.github/workflows/ci.yml
Outdated
| @@ -31,7 +31,7 @@ jobs: | |||
| uses: actions/setup-java@v4 | |||
| with: | |||
| distribution: corretto | |||
| java-version: '17' | |||
| java-version: '11' | |||
There was a problem hiding this comment.
This was on purpose using Java17 because it's faster than Java11 and it's the same for all the 17 that you replaced with 11 in this file.
The important thing is that your tests are run on the 3 versions, which is already the case. See https://github.com/zio/zio-sbt/pull/399/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR67-R77
There was a problem hiding this comment.
I'll change the wording in setting key then because it's a bit confusing
guizmaii
reviewed
May 27, 2024
| @@ -109,7 +109,7 @@ object ZioSbtEcosystemPlugin extends AutoPlugin { | |||
| scalaVersion := scala213.value, | |||
| crossScalaVersions := Seq(scala212.value, scala213.value, scala3.value), | |||
| zioVersion := Versions.zioVersion, | |||
| javaPlatform := "8" | |||
| javaPlatform := "11" | |||
Restore Java 17
guizmaii
approved these changes
May 28, 2024
|
@andrzejressel Thanks for your contribution 🙂 |
Merged
guizmaii
added a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was migrating zio-logging to latest version and I've noticed some inconsistencies regarding Java version. While most of them are minor the release one caught my eye.
This PR:
Sets default release Java to 11 - I believe libraries are released for Java 11 anyway, because of "source/target" flags, but it looks strange when docs are saying that Java 17 is default for release.I've added more descriptive commentShouldn'tjavacOptionsbe removed altogether to ensure that tests on latest Java are actually using the new features?