-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a validation constructor for IPv6 #258
Comments
I will take this one. |
Hey, I was working on the IPv6 validation and realised it's non-trivial. What's missing? I will try to prepare more test cases to find various border cases. There is also one thing to clarify. A test case in the current implementation expects a valid IPv6 address to be incorrect. I mean this test scenario: I prepared the ground for extensions and fixes via some other PRs (merged), and I will try to continue here if you don't mind. |
Hello @baldram, go ahead, fix it, actually I based this first approach on http://jsfiddle.net/AJEzQ/ and http://jsfiddle.net/DanielD/8S4nq/ But honestly, I can't remember the code I made this morning 😆 Regards! |
A bugfix for leading zeros support is delivered. That was a quick win. As mentioned, when I started with the task, I discovered many incomplete regexes on the internet. Moreover, a current validator is very basic, and many cases still exist to implement.
I will book some time to prepare good test scenarios and fill gaps in the current implementation. |
Implement an ipv6 validator
The text was updated successfully, but these errors were encountered: