Add implementation of hashCode method for Dynamic Value along with the corresponding test #696
Conversation
|
@jdegoes This is ready for review. Thanks! |
|
Unfortunately, the job is bigger than just hash code. You also need to fix equality. In addition, the test suite needs to be more comprehensive, verifying that different ways of creating equivalent dynamic value compare and hash equal. I will increase the bounty on this one as there is more work than I thought. |
|
@jdegoes I have fixed equality as well by overriding the |
|
@jdegoes Just a gentle reminder to please review this! Thanks! |
|
@jdegoes Really sorry to bother you! Just a gentle reminder. Thanks! |
|
@jdegoes Just a gentle reminder! Thanks! |
tests/shared/src/test/scala-2/zio/schema/DynamicValueSpec.scala
Outdated
Show resolved
Hide resolved
tests/shared/src/test/scala-2/zio/schema/DynamicValueSpec.scala
Outdated
Show resolved
Hide resolved
|
@BijenderKumar1 The tests are not testing anything robust. A robust test will be property-based, using dynamically generated |
|
@jdegoes Thanks for the review. I have added a new function to dynamically generate |
|
@jdegoes Just a gentle reminder to review this. Thanks! |
|
@jdegoes Just a gentle reminder to review this. Thanks! |
|
@jdegoes Just a gentle reminder to review this. Really sorry to bother you repeatedly! Thanks! |
|
@jdegoes Hope you are doing well! Just a gentle reminder for reviewing this. Thanks! |
|
@BijenderKumar1 There are still issues. I'll write once I have the time for it |
|
@987Nabil No worries! I will be super happy to incorporate your suggestions. Thanks! |
|
@jdegoes Hope you are doing well! Just a gentle reminder to please review this. Thanks! |
/claim #655
In order to resolve the issue of incosistent
hashCodevalues forDynamicValueobjects, I have added an implementation of thehashCodemethod for theDynamicValueclass. I have also added a test to ensure that thehashCodevalues are consistent. Thanks!