Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nokogiri version. #4

Open
farooqch11 opened this issue Apr 3, 2020 · 13 comments
Open

fix nokogiri version. #4

farooqch11 opened this issue Apr 3, 2020 · 13 comments
Assignees

Comments

@farooqch11
Copy link

Bundler could not find compatible versions for gem "nokogiri":
In snapshot (Gemfile.lock):
nokogiri (= 1.10.9)

In Gemfile:
fishbowl was resolved to 0.0.3, which depends on
nokogiri (~> 1.5.5)

@zion
Copy link
Owner

zion commented Apr 3, 2020

hey, I had this problem too a while ago. Havent taken the time to address the issue in the gem. I'll try to do that really soon.

As a work around, Im just using the gem from github.

gem 'fishbowl', :git => 'https://github.com/zion/fishbowl.git'

This isnt ideal, I know. But it worked for me. I'll try to get the gem updated on rubygems soon!

@zion
Copy link
Owner

zion commented Apr 3, 2020

@farooqch11 Ok, I decided to just do this now.

Pushed the gem as v1.0

Try gem 'fishbowl', '~> 1.0'

I was able to bundle install but havent tested my app yet. But its the same codebase as I was using before. Let me know if you have issues.

@zion zion self-assigned this Apr 3, 2020
@farooqch11
Copy link
Author

Thanks for such a quick response.

is there any documentation for all methods we have in the gem, i need to fetch products, orders, and other details also.

@zion
Copy link
Owner

zion commented Apr 5, 2020

There isn’t. I inherited this gem a while ago when the original author no longer used it or supported it.

Fishbowl has some documentation for the different requests but it’s not great to be honest.

@farooqch11
Copy link
Author

farooqch11 commented Apr 5, 2020 via email

@zion
Copy link
Owner

zion commented Apr 5, 2020

Sounds awesome!

I currently only use a couple of the request methods. Save and retrieve SO. so it’s very possible some of them don’t work correctly

@farooqch11
Copy link
Author

farooqch11 commented Apr 5, 2020 via email

@farooqch11
Copy link
Author

@zion can you guide little bit to me , how can i add new request methods in this gem and make it work for my project only? easy way to add new requests in my project by using this gem functions.

@zion
Copy link
Owner

zion commented Apr 10, 2020

You can add more request classes if you'd like and make a PR... or you could fork this and add them in your fork.

What kind of new requests?

@farooqch11
Copy link
Author

farooqch11 commented Apr 10, 2020 via email

@zion
Copy link
Owner

zion commented Apr 10, 2020

@farooqch11
Copy link
Author

farooqch11 commented Apr 10, 2020 via email

@zion
Copy link
Owner

zion commented Apr 10, 2020

There is not.

All the request objects now use a base class that uses an xml structure. We would have to create a new base class or build some other mechanism for json type requests. Which isnt a big deal, but does not exist yet.

Heres what we can do, if you are willing, you can add a new request object for execute query. You can use this as an example: https://github.com/zion/fishbowl/blob/master/lib/fishbowl/requests/get_product.rb

Instead of: Fishbowl::Objects::BaseObject.new.send_request(builder, "ProductGetRs")

We can build a new object class for json requests, and do something like:

Fishbowl::Objects::JsonObject.new.send_request(builder, 'ExecuteQueryRq')

All of this is purely speculative, however I think it should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants