-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nokogiri version. #4
Comments
hey, I had this problem too a while ago. Havent taken the time to address the issue in the gem. I'll try to do that really soon. As a work around, Im just using the gem from github.
This isnt ideal, I know. But it worked for me. I'll try to get the gem updated on rubygems soon! |
@farooqch11 Ok, I decided to just do this now. Pushed the gem as v1.0 Try I was able to |
Thanks for such a quick response. is there any documentation for all methods we have in the gem, i need to fetch products, orders, and other details also. |
There isn’t. I inherited this gem a while ago when the original author no longer used it or supported it. Fishbowl has some documentation for the different requests but it’s not great to be honest. |
Oh, i think i will put some efforst to put docs ?
…On Sun, 5 Apr 2020, 5:42 pm Simeon, ***@***.***> wrote:
There isn’t. I inherited this gem a while ago when the original author no
longer used it or supported it.
Fishbowl has some documentation for the different requests but it’s not
great to be honest.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIFWI22LQQS24FRVENH2ADLRLB4EFANCNFSM4L4L3MEQ>
.
|
Sounds awesome! I currently only use a couple of the request methods. Save and retrieve SO. so it’s very possible some of them don’t work correctly |
Possible then i will check if something doest work and will update in
separate branch
…On Sun, 5 Apr 2020, 5:48 pm Simeon, ***@***.***> wrote:
Sounds awesome!
I currently only use a couple of the request methods. Save and retrieve
SO. so it’s very possible some of them don’t work correctly
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIFWI23EFYEKO6TGWF37GKTRLB4YDANCNFSM4L4L3MEQ>
.
|
@zion can you guide little bit to me , how can i add new request methods in this gem and make it work for my project only? easy way to add new requests in my project by using this gem functions. |
You can add more request classes if you'd like and make a PR... or you could fork this and add them in your fork. What kind of new requests? |
I have custom made queries in fishbowl, named queries, i wanna fetch those.
Like all products, updated products, images for single product.
…On Sat, 11 Apr 2020, 12:33 am Simeon, ***@***.***> wrote:
You can add more request classes if you'd like and make a PR... or you
could fork this and add them in your fork.
What kind of new requests?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIFWI23HYHZB5WD5Q3VYDPTRL5YAPANCNFSM4L4L3MEQ>
.
|
Could we use this? https://www.fishbowlinventory.com/wiki/Fishbowl_API#Execute_Query |
Yes, this is needed!
Do we have any this request type in the gem already?
…On Sat, 11 Apr 2020, 12:38 am Simeon, ***@***.***> wrote:
Could we use this?
https://www.fishbowlinventory.com/wiki/Fishbowl_API#Execute_Query
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIFWI24NUZX4IN5FTXDJTZLRL5YR3ANCNFSM4L4L3MEQ>
.
|
There is not. All the request objects now use a base class that uses an xml structure. We would have to create a new base class or build some other mechanism for json type requests. Which isnt a big deal, but does not exist yet. Heres what we can do, if you are willing, you can add a new request object for execute query. You can use this as an example: https://github.com/zion/fishbowl/blob/master/lib/fishbowl/requests/get_product.rb Instead of: We can build a new object class for json requests, and do something like:
All of this is purely speculative, however I think it should work |
Bundler could not find compatible versions for gem "nokogiri":
In snapshot (Gemfile.lock):
nokogiri (= 1.10.9)
In Gemfile:
fishbowl was resolved to 0.0.3, which depends on
nokogiri (~> 1.5.5)
The text was updated successfully, but these errors were encountered: