Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use indexmap in read::zip_archive::Shared instead of a separate vec and hashmap #74

Closed
wants to merge 6 commits into from
Closed

perf: use indexmap in read::zip_archive::Shared instead of a separate vec and hashmap #74

wants to merge 6 commits into from

Conversation

cosmicexplorer
Copy link
Contributor

See zip-rs/zip-old#396. Closes #50.

@cosmicexplorer cosmicexplorer changed the title use indexmap perf: use indexmap in read::zip_archive::Shared instead of a separate vec and hashmap May 2, 2024
@cosmicexplorer cosmicexplorer mentioned this pull request May 2, 2024
Closed
@Pr0methean Pr0methean enabled auto-merge May 2, 2024 20:08
@Pr0methean Pr0methean added the waiting to be automatically merged If this PR isn't automatically merged, suspect a broader issue. label May 2, 2024
@Pr0methean Pr0methean added this pull request to the merge queue May 3, 2024
@Pr0methean Pr0methean removed this pull request from the merge queue due to a manual request May 3, 2024
@Pr0methean Pr0methean added merge conflict This PR has a merge conflict with a PR that was in the merge queue when this label was applied. and removed waiting to be automatically merged If this PR isn't automatically merged, suspect a broader issue. labels May 3, 2024
@Pr0methean Pr0methean added waiting to be automatically merged If this PR isn't automatically merged, suspect a broader issue. and removed merge conflict This PR has a merge conflict with a PR that was in the merge queue when this label was applied. labels May 3, 2024
@Pr0methean Pr0methean mentioned this pull request May 3, 2024
Closed
@Pr0methean
Copy link
Member

Replaced with #88 so I could commit a fix for the conflicts with other recently-merged PRs.

@Pr0methean Pr0methean closed this May 3, 2024
@Pr0methean Pr0methean removed the waiting to be automatically merged If this PR isn't automatically merged, suspect a broader issue. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosmicexplorer @Pr0methean