Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): slice init length for prompt #658

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Oct 4, 2024

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

The intention here should be to initialize a slice with a capacity of len(oidcPrompt rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.09%. Comparing base (0992c5f) to head (c7d24a5).
Report is 95 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   60.06%   62.09%   +2.03%     
==========================================
  Files          80       81       +1     
  Lines        6998     6218     -780     
==========================================
- Hits         4203     3861     -342     
+ Misses       2498     2047     -451     
- Partials      297      310      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhlemmer muhlemmer changed the title fix: fix slice init length fix(example): slice init length for prompt Oct 4, 2024
@muhlemmer muhlemmer merged commit 97d7b28 into zitadel:main Oct 4, 2024
8 checks passed
Copy link

github-actions bot commented Oct 4, 2024

🎉 This PR is included in version 3.30.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants