feat: adding ssri.create for a crypto style interface #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding crypto.create adding toJSON to Integrity
zkat
approved these changes
Apr 6, 2017
index.js
Outdated
| function createIntegrity (opts) { | ||
| opts = opts || {} | ||
|
|
||
| opts = opts || {} |
README.md
Outdated
| Returns the string representation of an `Integrity` object. All hash entries | ||
| will be concatenated in the string by `' '`. | ||
|
|
||
| this is a convenience method so you can pass an `Integrity` object directly to `JSON.stringify` |
README.md
Outdated
| will be concatenated in the string by `' '`. | ||
|
|
||
| this is a convenience method so you can pass an `Integrity` object directly to `JSON.stringify` | ||
| this works with the built in native JSON feature. For more info check out [toJSON() behavior on mdn](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#toJSON%28%29_behavior) |
There was a problem hiding this comment.
Minor nit: period at end of sentence?
README.md
Outdated
| #### <a name="create"></a> `> ssri.create([opts]) -> <Integrity>` | ||
|
|
||
| Returns an Integrity object calculated by reading data from | ||
| calls to update |
create was misdocumented as returning Integrity but it return a Hash
zkat
approved these changes
Apr 7, 2017
|
=) feel free to merge when you are ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding crypto.create
adding toJSON to Integrity