chore: fix build issue in twitter app

zkemail · Aug 31, 2023 · 245013e · 245013e
1 parent 12a4230
commit 245013e
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 19 deletions.
diff --git a/package.json b/package.json
@@ -22,6 +22,6 @@
     "jest": "^29.5.0",
     "ts-jest": "^29.1.0",
     "ts-node": "^10.9.1",
-    "typescript": "^5.1.6"
+    "typescript": "^5.2.2"
   }
 }
diff --git a/packages/twitter-verifier-app/package.json b/packages/twitter-verifier-app/package.json
@@ -25,7 +25,7 @@
   },
   "scripts": {
     "start": "vite",
-    "build": "vite build",
+    "build": "yarn g:tsc && vite build",
     "serve": "vite preview",
     "test": "jest --runInBand --testPathIgnorePatterns='e2e' --reporters=default --reporters=jest-junit",
     "start-e2e-test-server": "serve -s dist -p 3000",
@@ -73,7 +73,6 @@
     "puppeteer": "18.1",
     "rollup-plugin-node-polyfills": "^0.2.1",
     "selenium-webdriver": "^4.8.1",
-    "typescript": "^4.8.4",
     "vite-plugin-commonjs": "^0.7.1",
     "vite-plugin-ngmi-polyfill": "^0.0.2",
     "vite-plugin-node-polyfills": "^0.8.2",

diff --git a/packages/twitter-verifier-app/pages/MainPage.tsx b/packages/twitter-verifier-app/pages/MainPage.tsx
@@ -125,7 +125,7 @@ export const MainPage: React.FC<{}> = (props) => {
   };
 
   const reformatProofForChain = (proofStr: string) => {
-    if (!proofStr) return Array(8).fill("0");
+    if (!proofStr) return [];
 
     const proof = JSON.parse(proofStr);
 
@@ -142,9 +142,9 @@ export const MainPage: React.FC<{}> = (props) => {
     functionName: "mint",
     args: [
       reformatProofForChain(proof),
-      publicSignals ? JSON.parse(publicSignals) : Array(5).fill("0"),
+      publicSignals ? JSON.parse(publicSignals) : [],
     ],
-
+    enabled: !!(proof && publicSignals),
     onError: (error: { message: any }) => {
       console.error(error.message);
       // TODO: handle errors

diff --git a/packages/twitter-verifier-app/tsconfig.json b/packages/twitter-verifier-app/tsconfig.json
@@ -3,8 +3,8 @@
   "include": ["."],
   "exclude": ["tests", "dist"],
   "compilerOptions": {
+    "skipLibCheck": true,
     "module": "esnext",
-    "baseUrl": "./",
     "noEmit": true
   }
 }
diff --git a/yarn.lock b/yarn.lock
@@ -4520,7 +4520,6 @@ __metadata:
     serve: ^14.0.1
     snarkjs: "https://github.com/sampritipanda/snarkjs.git#fef81fc51d17a734637555c6edbd585ecda02d9e"
     styled-components: ^5.3.5
-    typescript: ^4.8.4
     vite: ^4.4.9
     vite-plugin-commonjs: ^0.7.1
     vite-plugin-ngmi-polyfill: ^0.0.2
@@ -13529,7 +13528,7 @@ __metadata:
     jest: ^29.5.0
     ts-jest: ^29.1.0
     ts-node: ^10.9.1
-    typescript: ^5.1.6
+    typescript: ^5.2.2
   languageName: unknown
   linkType: soft
 
@@ -14928,7 +14927,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript@npm:^4.0.0, typescript@npm:^4.8.4, typescript@npm:^4.9.5":
+"typescript@npm:^4.0.0, typescript@npm:^4.9.5":
   version: 4.9.5
   resolution: "typescript@npm:4.9.5"
   bin:
@@ -14938,13 +14937,13 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript@npm:^5.1.6":
-  version: 5.1.6
-  resolution: "typescript@npm:5.1.6"
+"typescript@npm:^5.2.2":
+  version: 5.2.2
+  resolution: "typescript@npm:5.2.2"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: b2f2c35096035fe1f5facd1e38922ccb8558996331405eb00a5111cc948b2e733163cc22fab5db46992aba7dd520fff637f2c1df4996ff0e134e77d3249a7350
+  checksum: 7912821dac4d962d315c36800fe387cdc0a6298dba7ec171b350b4a6e988b51d7b8f051317786db1094bd7431d526b648aba7da8236607febb26cf5b871d2d3c
   languageName: node
   linkType: hard
 
@@ -14958,7 +14957,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript@patch:typescript@^4.0.0#~builtin<compat/typescript>, typescript@patch:typescript@^4.8.4#~builtin<compat/typescript>, typescript@patch:typescript@^4.9.5#~builtin<compat/typescript>":
+"typescript@patch:typescript@^4.0.0#~builtin<compat/typescript>, typescript@patch:typescript@^4.9.5#~builtin<compat/typescript>":
   version: 4.9.5
   resolution: "typescript@patch:typescript@npm%3A4.9.5#~builtin<compat/typescript>::version=4.9.5&hash=a1c5e5"
   bin:
@@ -14968,13 +14967,13 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript@patch:typescript@^5.1.6#~builtin<compat/typescript>":
-  version: 5.1.6
-  resolution: "typescript@patch:typescript@npm%3A5.1.6#~builtin<compat/typescript>::version=5.1.6&hash=a1c5e5"
+"typescript@patch:typescript@^5.2.2#~builtin<compat/typescript>":
+  version: 5.2.2
+  resolution: "typescript@patch:typescript@npm%3A5.2.2#~builtin<compat/typescript>::version=5.2.2&hash=a1c5e5"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: 21e88b0a0c0226f9cb9fd25b9626fb05b4c0f3fddac521844a13e1f30beb8f14e90bd409a9ac43c812c5946d714d6e0dee12d5d02dfc1c562c5aacfa1f49b606
+  checksum: 07106822b4305de3f22835cbba949a2b35451cad50888759b6818421290ff95d522b38ef7919e70fb381c5fe9c1c643d7dea22c8b31652a717ddbd57b7f4d554
   languageName: node
   linkType: hard