Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added Header Masking #216

Merged
merged 8 commits into from
Sep 13, 2024
Merged

Feat: Added Header Masking #216

merged 8 commits into from
Sep 13, 2024

Conversation

shreyas-londhe
Copy link
Member

Description

This PR introduces header masking.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Copy link
Member

@saleel saleel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@saleel
Copy link
Member

saleel commented Sep 9, 2024

Circuit tests are failing here, but passes locally 🤔
Maybe we reach some limits on Github action containers.

@shreyas-londhe
Copy link
Member Author

shreyas-londhe commented Sep 13, 2024

Circuit tests are failing here, but passes locally 🤔 Maybe we reach some limits on Github action containers.

@saleel It didn't run the tests for my latest commit. I didn't change the workflow file. Do you know what happened?

@saleel
Copy link
Member

saleel commented Sep 13, 2024

@shreyas-londhe No idea, thats odd. Try opening another one with same branch. Or maybe add another commit here.

@shreyas-londhe
Copy link
Member Author

@saleel @Divide-By-0 please review the changes and merge if everything is good :)

@Divide-By-0 Divide-By-0 merged commit fc99497 into main Sep 13, 2024
5 checks passed
@shreyas-londhe shreyas-londhe deleted the feat/header-masking branch September 13, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants