Bugfixes #43
Merged
Bugfixes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS parsing of DKIM key rarely failed due to extra quotes, now fixed
Added notes to readmes about these failures
Either solidity tests failed or deploy failed, fixed via mega hack (thanks to comment below in support channel)
I also had lots of issues with dynamic library linking not working for deploying contracts (and the same error with Dynamic linking not supported in create command when doing —libraries). when I tried to add libraries = [] to foundry.toml, all of my tests broke, so this was the only solution that worked for me instead (ugly i know but it seems to be the only way to do it in foundry, idk why libraries in .toml and —libraries operate so differently):
forge create --rpc-url $ETH_RPC_URL LIB1 --private-key$SK --via-ir --force | tee /dev/tty | export LIB1_ADDR=$ (sed -n 's/.*Deployed to: //p')
forge create --rpc-url $ETH_RPC_URL LIB2 --private-key$SK --via-ir --force | tee /dev/tty | export LIB2_ADDR=$ (sed -n 's/.*Deployed to: //p')
echo "libraries = ["src/LIB1.sol:LIB1:${LIB1_ADDR}", "src/LIB2.sol:LIB2:${LIB2_ADDR}"]" >> foundry.toml
forge create --rpc-url $ETH_RPC_URL MainContract --private-key $SK --libraries LIB2:$LIB2_ADDR,LIB1:$LIB1_ADDR --via-ir --force | tee /dev/tty | export MAINCONTRACT_ADDR=$(sed -n 's/.*Deployed to: //p')
sed -i '' -e '$ d' foundry.toml