-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix all lints #100
Closed
Closed
chore: fix all lints #100
Commits on Jun 16, 2024
-
There's a lot of changes - I'll briefly summarize what I did: I ran, as much as possible, the following: ```rust cargo fix --all --allow-dirty cargo fmt cargo clippy --fix --all --allow--dirty ``` Some parts, I had to manually fix, or was out of scope of the current PR, so I added lint allowances + TODOs instead. An example of such 'out of scope' fixes include the `unused_must_use`s in `r1cs/snarkjs.rs` - these would require additional work on error handling which should probably belong in its own PR. For these cases, I prefer lint allowances since they allow us to easily find the spots where we want to fix later on. Note that some of the lint allowances seem sane, so I didn't add TODOs for those, but only for those I felt would improve code quality if removed.
Configuration menu - View commit details
-
Copy full SHA for bf81934 - Browse repository at this point
Copy the full SHA bf81934View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0e96c1 - Browse repository at this point
Copy the full SHA d0e96c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5320eaa - Browse repository at this point
Copy the full SHA 5320eaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8765baa - Browse repository at this point
Copy the full SHA 8765baaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6133479 - Browse repository at this point
Copy the full SHA 6133479View commit details -
Configuration menu - View commit details
-
Copy full SHA for d55ca82 - Browse repository at this point
Copy the full SHA d55ca82View commit details
Commits on Jun 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8d0992c - Browse repository at this point
Copy the full SHA 8d0992cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ec541a - Browse repository at this point
Copy the full SHA 2ec541aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b1beaa - Browse repository at this point
Copy the full SHA 8b1beaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96f903a - Browse repository at this point
Copy the full SHA 96f903aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09b5bcc - Browse repository at this point
Copy the full SHA 09b5bccView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.