Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix all lints #100

Closed
wants to merge 11 commits into from
Closed

Commits on Jun 16, 2024

  1. chore: fix all lints

    There's a lot of changes - I'll briefly summarize what I did:
    
    I ran, as much as possible, the following:
    
    ```rust
    cargo fix --all --allow-dirty
    cargo fmt
    cargo clippy --fix --all --allow--dirty
    ```
    
    Some parts, I had to manually fix, or was out of scope of the current PR,
    so I added lint allowances + TODOs instead. An example of such 'out of scope'
    fixes include the `unused_must_use`s in `r1cs/snarkjs.rs` - these would require
    additional work on error handling which should probably belong in its own PR.
    For these cases, I prefer lint allowances since they allow us to easily find the spots
    where we want to fix later on.
    
    Note that some of the lint allowances seem sane, so I didn't add TODOs for those,
    but only for those I felt would improve code quality if removed.
    bing authored and eightfilms committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    bf81934 View commit details
    Browse the repository at this point in the history
  2. re-enable clippy

    bing authored and eightfilms committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    d0e96c1 View commit details
    Browse the repository at this point in the history
  3. chore: more clippy fixes for snarkjs.rs

    bing authored and eightfilms committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    5320eaa View commit details
    Browse the repository at this point in the history
  4. resolve merge

    eightfilms committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    8765baa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6133479 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d55ca82 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. fix redundant double slash

    eightfilms committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8d0992c View commit details
    Browse the repository at this point in the history
  2. use collect_vec

    eightfilms committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2ec541a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8b1beaa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    96f903a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    09b5bcc View commit details
    Browse the repository at this point in the history