Support both stone v5 and v6 binaries #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update README and make prover/verifier errors more expressive
- change from downloading executables/corelib directly to `.stone-cli` directory to downloading them to tmp directory first, verifying them and then copying them into the `.stone-cli` directory - change corelib location from `.stone-cli` to `.stone-cli/v0.1.0` and executables location to `.stone-cli/v0.1.0/executables`. This allows versioning of the corelib directory over multiple stone-cli versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ethereum verifier can only verify stone v5 proofs (stone v6 additionally includes the
n_verifier_friendly_commitment_layersvalue when computing the public input hash), which means that we need to install stone v5 when running commands likeprove_bootloaderandserialize --network ethereum. Also, the starknet verifier can verify stone v5 and v6 proofs.Alternative is to use features to selectively install v5 and v6 binaries, but the combined increase in the size of binaries installed is only around 40mb, which does not seem too bad.
Also addresses this issue by writing to tmp directory first, verifying them, and then copying them over to the
.stone-clidirectory.