Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way to disable 'Warning: Limited encoding support'? #481

Closed
vszakats opened this issue May 26, 2020 · 4 comments
Closed

Way to disable 'Warning: Limited encoding support'? #481

vszakats opened this issue May 26, 2020 · 4 comments
Labels
build system Build system and script changes fixed Issue or bug has been fixed

Comments

@vszakats
Copy link
Contributor

vszakats commented May 26, 2020

This warning is now permanently shown when building without iconv. While understanding the drawbacks, I'd argue that there may be cases/platforms where building against iconv isn't practical or isn't necessary. E.g. on Windows, building iconv is a challenge and even when done, it's a large dependency that needs to be shipped around. In cases where minizip2 is used in a controlled environment with known, or pure-ASCII filenames, it can work well without codepage conversion.

It'd be nice to have a way to avoid this warning and silently fall back to the transparent strncpy() method.

@nmoinvaz
Copy link
Member

Do you have any suggestions? Maybe we should only mention this in CMake?

@vszakats
Copy link
Contributor Author

Moving that (a.) to CMake would be nice, or, (b.) implement a #define specifically to enable the non-iconv branch (e.g. MZ_ENCODING_TRANSPARENT), or (c.) a HAVE_NO_ICONV #define which would have the same effect as no HAVE_ICONV, but would suppress the warning.

[ My preference is (a.), (c.), (b.) ]

@nmoinvaz
Copy link
Member

nmoinvaz commented May 26, 2020

I think we should do CMake too. Do you want to do a PR?

@vszakats
Copy link
Contributor Author

I'm not a "CMake-person", so I'd trust yours much better for this solution.

@nmoinvaz nmoinvaz added 2.0 build system Build system and script changes fixed Issue or bug has been fixed labels Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Build system and script changes fixed Issue or bug has been fixed
Projects
None yet
Development

No branches or pull requests

2 participants