-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Way to disable 'Warning: Limited encoding support'? #481
Comments
Do you have any suggestions? Maybe we should only mention this in CMake? |
Moving that (a.) to CMake would be nice, or, (b.) implement a [ My preference is (a.), (c.), (b.) ] |
I think we should do CMake too. Do you want to do a PR? |
I'm not a "CMake-person", so I'd trust yours much better for this solution. |
This warning is now permanently shown when building without
iconv
. While understanding the drawbacks, I'd argue that there may be cases/platforms where building againsticonv
isn't practical or isn't necessary. E.g. on Windows, buildingiconv
is a challenge and even when done, it's a large dependency that needs to be shipped around. In cases where minizip2 is used in a controlled environment with known, or pure-ASCII filenames, it can work well without codepage conversion.It'd be nice to have a way to avoid this warning and silently fall back to the transparent
strncpy()
method.The text was updated successfully, but these errors were encountered: