Added mz_zip_rw.*, mz_strm_split.* files to podspec. Use system bzip2… #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for subspec BZIP2.
|
@Coeur thoughts? |
|
I think it might be better to have a |
|
Thanks! |
|
So, a bit late for the review, but Nathan is right, having two distinct subspecs here is better. In the future, we may change the default_subspecs to use BZIP2_SYSTEM if it works on all platforms (macOS, iOS, ...), but that is something that I haven't analyzed at all. Regarding mz_zip_rw.* and mz_strm_spli.*, good catch, as I'm definitely using those: https://github.com/ZipArchive/ZipArchive/tree/master/SSZipArchive/minizip So, all is good in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for subspec BZIP2.