mz_compat: sync parameter types with minizip1, add 2 compatibility wrappers #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrappers
- zipOpenNewFileInZip*(): method/compression_method is 'int' in minizip1
- zipCloseFileInZipRaw64(): uncompressed_size is 'ZPOS64_T', which is 'uint64_t'
- unzTell64(): return value is 'ZPOS64_T', which is 'uint64_t'
- unztell(): return value should be 32-bit
- add unztell64() (full lowercase), which is the same as unzTell64()
- add unzeof(), which is the same as unzEndOfFile()
NOTE: It'd be probably useful to update mz_zip_entry_close_raw() uncompressed_size
type to unsigned.
Can you please explain? |
|
This way the lower level type would match the type of higher level (compatibility) APIs, and it would also match the unsigned type used throughout the original minizip library. Given the file sizes involved, it's rather an academic than practical issue. Thank you for merging! |
|
I think I am okay with leaving it as is for now. I use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: It'd be probably useful to update mz_zip_entry_close_raw() uncompressed_size type to unsigned.