Make mz_crypt_openssl.c work with BoringSSL #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoringSSL does not provide cms.h but this is an optional dependency for minizip, conditional on defined(MZ_ZIP_SIGNING). For the functions called by mz_crypt_init: - The OpenSSL_add_all_algorithms function is declared in evp.h. OpenSSL's hmac.h includes evp.h but BoringSSL's hmac.h does not. - The ERR_* functions are declared in err.h in both. - The ENGINE_* functions are declared in engine.h in OpenSSL but are in crypto.h for BoringSSL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoringSSL does not provide cms.h but this is an optional dependency for
minizip, conditional on defined(MZ_ZIP_SIGNING).
For the functions called by mz_crypt_init:
OpenSSL's hmac.h includes evp.h but BoringSSL's hmac.h does not.
crypto.h for BoringSSL.