Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SOVERSION in Linux #592

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Fix SOVERSION in Linux #592

merged 1 commit into from
Sep 1, 2021

Conversation

Iniesta8
Copy link
Contributor

In Linux (and BSD) the SOVERSION only consists of the major version number. The correct symbolic links have to be

libminizip.so -> libminizip.so.3
libminizip.so.3 -> libminizip.so.3.0.2
libminizip.so.3.0.2

and the SONAME of libminizip.so.3.0.2 is libminizip.so.3. By this change the symbolic links are created correctly.

On other platforms, such as Windows and macOS, the SOVERSION may well consist of <major-minor>. That's why I added the if-else statement.

See also: https://cmake.org/cmake/help/latest/prop_tgt/SOVERSION.html

@nmoinvaz
Copy link
Member

I'm okay if it just says "3" with no if statement.

@Iniesta8
Copy link
Contributor Author

Iniesta8 commented Sep 1, 2021

update, without platform differentiation.

@nmoinvaz nmoinvaz merged commit f53e7c2 into zlib-ng:master Sep 1, 2021
@Iniesta8 Iniesta8 deleted the fix-soname branch September 1, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants